projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d737b55
)
[Remarks] Fix mismatched delete due to missing virtual destructor
author
Jordan Rupprecht
<rupprecht@google.com>
Wed, 20 Mar 2019 17:44:24 +0000
(17:44 +0000)
committer
Jordan Rupprecht
<rupprecht@google.com>
Wed, 20 Mar 2019 17:44:24 +0000
(17:44 +0000)
This fixes an asan failure introduced in r356519.
llvm-svn: 356583
llvm/lib/Remarks/RemarkParserImpl.h
patch
|
blob
|
history
diff --git
a/llvm/lib/Remarks/RemarkParserImpl.h
b/llvm/lib/Remarks/RemarkParserImpl.h
index 6804657f9bff3c96c74487ef020b11b760e5f5f9..b4c106badf6b66ab614cd10f2096e6be3cafc67e 100644
(file)
--- a/
llvm/lib/Remarks/RemarkParserImpl.h
+++ b/
llvm/lib/Remarks/RemarkParserImpl.h
@@
-19,6
+19,10
@@
namespace remarks {
struct ParserImpl {
enum class Kind { YAML };
+ explicit ParserImpl(Kind TheParserKind) : ParserKind(TheParserKind) {}
+ // Virtual destructor prevents mismatched deletes
+ virtual ~ParserImpl() {}
+
// The parser kind. This is used as a tag to safely cast between
// implementations.
Kind ParserKind;