habanalabs: remove duplicate check
authorOded Gabbay <ogabbay@kernel.org>
Mon, 12 Oct 2020 17:56:33 +0000 (20:56 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 30 Nov 2020 08:47:28 +0000 (10:47 +0200)
We already check if queue index is smaller than max queues a few lines
above this check so no need to check this again.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/command_submission.c

index df6393a..0e37aad 100644 (file)
@@ -946,9 +946,10 @@ static int cs_ioctl_signal_wait(struct hl_fpriv *hpriv, enum hl_cs_type cs_type,
        hw_queue_prop = &hdev->asic_prop.hw_queues_props[q_idx];
        q_type = hw_queue_prop->type;
 
-       if ((q_idx >= hdev->asic_prop.max_queues) ||
-                       (!hw_queue_prop->supports_sync_stream)) {
-               dev_err(hdev->dev, "Queue index %d is invalid\n", q_idx);
+       if (!hw_queue_prop->supports_sync_stream) {
+               dev_err(hdev->dev,
+                       "Queue index %d does not support sync stream operations\n",
+                       q_idx);
                rc = -EINVAL;
                goto free_cs_chunk_array;
        }