remoteproc: return -EFAULT on copy_from_user failure
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Sep 2012 07:05:33 +0000 (10:05 +0300)
committerOhad Ben-Cohen <ohad@wizery.com>
Sun, 30 Sep 2012 09:44:53 +0000 (11:44 +0200)
copy_from_user() returns the number of bytes remaining to be copied, but
we want to return an error code here.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
drivers/remoteproc/remoteproc_debugfs.c

index ea90a56..157a573 100644 (file)
@@ -161,7 +161,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
 
        ret = copy_from_user(buf, user_buf, count);
        if (ret)
-               return ret;
+               return -EFAULT;
 
        /* remove end of line */
        if (buf[count - 1] == '\n')