RDMA/hns: Refactor irq request code
authorLang Cheng <chenglang@huawei.com>
Thu, 8 Aug 2019 14:53:49 +0000 (22:53 +0800)
committerDoug Ledford <dledford@redhat.com>
Mon, 12 Aug 2019 14:45:08 +0000 (10:45 -0400)
Remove unnecessary if...else..., to make the code look simpler.

Signed-off-by: Lang Cheng <chenglang@huawei.com>
Link: https://lore.kernel.org/r/1565276034-97329-10-git-send-email-oulijun@huawei.com
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 982b75bd3440ac2a24d66960773bc1a525ffd52f..049d66cdf659b11b650ada6525119a0d66099bdb 100644 (file)
@@ -5749,18 +5749,19 @@ static int __hns_roce_request_irq(struct hns_roce_dev *hr_dev, int irq_num,
        }
 
        /* irq contains: abnormal + AEQ + CEQ */
-       for (j = 0; j < irq_num; j++)
-               if (j < other_num)
-                       snprintf((char *)hr_dev->irq_names[j],
-                                HNS_ROCE_INT_NAME_LEN, "hns-abn-%d", j);
-               else if (j < (other_num + aeq_num))
-                       snprintf((char *)hr_dev->irq_names[j],
-                                HNS_ROCE_INT_NAME_LEN, "hns-aeq-%d",
-                                j - other_num);
-               else
-                       snprintf((char *)hr_dev->irq_names[j],
-                                HNS_ROCE_INT_NAME_LEN, "hns-ceq-%d",
-                                j - other_num - aeq_num);
+       for (j = 0; j < other_num; j++)
+               snprintf((char *)hr_dev->irq_names[j],
+                        HNS_ROCE_INT_NAME_LEN, "hns-abn-%d", j);
+
+       for (j = other_num; j < (other_num + aeq_num); j++)
+               snprintf((char *)hr_dev->irq_names[j],
+                        HNS_ROCE_INT_NAME_LEN, "hns-aeq-%d",
+                        j - other_num);
+
+       for (j = (other_num + aeq_num); j < irq_num; j++)
+               snprintf((char *)hr_dev->irq_names[j],
+                        HNS_ROCE_INT_NAME_LEN, "hns-ceq-%d",
+                        j - other_num - aeq_num);
 
        for (j = 0; j < irq_num; j++) {
                if (j < other_num)