gfs2: Silence possible null pointer dereference warning
authorAndreas Gruenbacher <agruenba@redhat.com>
Fri, 2 Apr 2021 17:51:24 +0000 (19:51 +0200)
committerAndreas Gruenbacher <agruenba@redhat.com>
Sat, 3 Apr 2021 19:38:12 +0000 (21:38 +0200)
In gfs2_rbm_find, rs is always NULL when minext is NULL, so
gfs2_reservation_check_and_update will never be called on a NULL minext.
This isn't innediately obvious though, so also check for a NULL minext
for better code readability.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/rgrp.c

index 89c37a8..2dab313 100644 (file)
@@ -1783,7 +1783,7 @@ static int gfs2_rbm_find(struct gfs2_rbm *rbm, u8 state, u32 *minext,
                        goto next_bitmap;
                }
                rbm->offset = offset;
-               if (!rs)
+               if (!rs || !minext)
                        return 0;
 
                ret = gfs2_reservation_check_and_update(rbm, rs, *minext,