Change the length of format for strlcpy 52/127252/2 accepted/tizen/unified/20170428.032504 submit/tizen/20170427.004342 tizen_4.0.m1_release
authorJiyong Min <jiyong.min@samsung.com>
Wed, 26 Apr 2017 23:30:55 +0000 (08:30 +0900)
committerJiyong Min <jiyong.min@samsung.com>
Wed, 26 Apr 2017 23:46:26 +0000 (08:46 +0900)
 [Problem] Copying 'RGBA8888' string make crash.
  (This issue happen after svace issue was fixed)
 [Solution] Change the length of string to copy

Change-Id: I741012cd0763b9c61bbc15fbc9bd307cbfd9d01c
Signed-off-by: jiyong min <jiyong.min@samsung.com>
gstcs/mm_util_gstcs.c
packaging/libmm-imgp-gstcs.spec

index 41ccb59..90d8f78 100755 (executable)
@@ -391,13 +391,13 @@ _mm_set_image_colorspace(image_format_s* __format)
        memset(__format->colorspace, 0, IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        if ((strcmp(__format->format_label, "I420") == 0) || (strcmp(__format->format_label, "Y42B") == 0) || (strcmp(__format->format_label, "Y444") == 0)
                || (strcmp(__format->format_label, "YV12") == 0) || (strcmp(__format->format_label, "NV12") == 0) || (strcmp(__format->format_label, "UYVY") == 0) || (strcmp(__format->format_label, "YUYV") == 0)) {
-               SAFE_STRCPY(__format->colorspace, "YUV", IMAGE_FORMAT_LABEL_BUFFER_SIZE-1);
+               SAFE_STRCPY(__format->colorspace, "YUV", IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        } else if ((strcmp(__format->format_label, "RGB888") == 0) || (strcmp(__format->format_label, "BGR888") == 0) || (strcmp(__format->format_label, "RGB565") == 0)) {
-               SAFE_STRCPY(__format->colorspace, "RGB", IMAGE_FORMAT_LABEL_BUFFER_SIZE-1);
+               SAFE_STRCPY(__format->colorspace, "RGB", IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        } else if ((strcmp(__format->format_label, "ARGB8888") == 0) || (strcmp(__format->format_label, "BGRA8888") == 0) || (strcmp(__format->format_label, "RGBA8888") == 0)  || (strcmp(__format->format_label, "ABGR8888") == 0)) {
-               SAFE_STRCPY(__format->colorspace, "RGBA", IMAGE_FORMAT_LABEL_BUFFER_SIZE-1);
+               SAFE_STRCPY(__format->colorspace, "RGBA", IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        } else if ((strcmp(__format->format_label, "BGRX") == 0)) {
-               SAFE_STRCPY(__format->colorspace, "BGRX", IMAGE_FORMAT_LABEL_BUFFER_SIZE-1);
+               SAFE_STRCPY(__format->colorspace, "BGRX", IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        } else {
                gstcs_error("Check your colorspace format label");
                GSTCS_FREE(__format->colorspace);
@@ -470,7 +470,7 @@ _mm_set_input_image_format_s_struct(imgp_info_s* pImgp_info) /* char* __format_l
                return NULL;
        }
        memset(__format->format_label, 0, IMAGE_FORMAT_LABEL_BUFFER_SIZE);
-       SAFE_STRCPY(__format->format_label, pImgp_info->input_format_label, IMAGE_FORMAT_LABEL_BUFFER_SIZE-1);
+       SAFE_STRCPY(__format->format_label, pImgp_info->input_format_label, IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        gstcs_debug("input_format_label: %s\n", pImgp_info->input_format_label);
        _mm_set_image_colorspace(__format);
 
@@ -525,7 +525,7 @@ _mm_set_output_image_format_s_struct(imgp_info_s* pImgp_info, const image_format
                return NULL;
        }
        memset(__format->format_label, 0, IMAGE_FORMAT_LABEL_BUFFER_SIZE);
-       SAFE_STRCPY(__format->format_label, pImgp_info->output_format_label, IMAGE_FORMAT_LABEL_BUFFER_SIZE-1);
+       SAFE_STRCPY(__format->format_label, pImgp_info->output_format_label, IMAGE_FORMAT_LABEL_BUFFER_SIZE);
        _mm_set_image_colorspace(__format);
 
        __format->width = pImgp_info->dst_width;
index 5dadba5..cd642d0 100755 (executable)
@@ -1,7 +1,7 @@
 #sbs-git:slp/pkgs/l/libmm-imgp-gstcs libmm-imgp-gstcs 0.1 62b62e6d483557fc5750d1b4986e9a98323f1194
 Name:       libmm-imgp-gstcs
 Summary:    Multimedia Framework Utility Library
-Version:    0.13
+Version:    0.14
 Release:    16
 Group:      System/Libraries
 License:    Apache-2.0