qed: Refuse to create images on block devices
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Fri, 14 Jan 2011 22:44:33 +0000 (22:44 +0000)
committerKevin Wolf <kwolf@redhat.com>
Mon, 24 Jan 2011 15:41:50 +0000 (16:41 +0100)
QED relies on the underlying filesystem to extend the file and maintain
its size.  Check that images are not created on a block device.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qed.c

index 085c4f2..a46f9ef 100644 (file)
@@ -469,6 +469,12 @@ static int qed_create(const char *filename, uint32_t cluster_size,
         return ret;
     }
 
+    /* File must start empty and grow, check truncate is supported */
+    ret = bdrv_truncate(bs, 0);
+    if (ret < 0) {
+        goto out;
+    }
+
     if (backing_file) {
         header.features |= QED_F_BACKING_FILE;
         header.backing_filename_offset = sizeof(le_header);