rnbd-srv: make process_msg_close returns void
authorGuoqing Jiang <guoqing.jiang@linux.dev>
Fri, 2 Sep 2022 10:00:54 +0000 (18:00 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 5 Sep 2022 17:46:42 +0000 (11:46 -0600)
Change the return type to void given it always returns 0.

Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Acked-by: Md Haris Iqbal <haris.iqbal@ionos.com>
Link: https://lore.kernel.org/r/20220902100055.25724-3-guoqing.jiang@linux.dev
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rnbd/rnbd-srv.c

index a229dd8..8d01165 100644 (file)
@@ -339,7 +339,7 @@ void rnbd_srv_sess_dev_force_close(struct rnbd_srv_sess_dev *sess_dev,
        mutex_unlock(&sess->lock);
 }
 
-static int process_msg_close(struct rnbd_srv_session *srv_sess,
+static void process_msg_close(struct rnbd_srv_session *srv_sess,
                             void *data, size_t datalen, const void *usr,
                             size_t usrlen)
 {
@@ -351,13 +351,12 @@ static int process_msg_close(struct rnbd_srv_session *srv_sess,
        sess_dev = rnbd_get_sess_dev(le32_to_cpu(close_msg->device_id),
                                      srv_sess);
        if (IS_ERR(sess_dev))
-               return 0;
+               return;
 
        rnbd_put_sess_dev(sess_dev);
        mutex_lock(&srv_sess->lock);
        rnbd_srv_destroy_dev_session_sysfs(sess_dev);
        mutex_unlock(&srv_sess->lock);
-       return 0;
 }
 
 static int process_msg_open(struct rnbd_srv_session *srv_sess,
@@ -387,7 +386,7 @@ static int rnbd_srv_rdma_ev(void *priv,
        case RNBD_MSG_IO:
                return process_rdma(srv_sess, id, data, datalen, usr, usrlen);
        case RNBD_MSG_CLOSE:
-               ret = process_msg_close(srv_sess, data, datalen, usr, usrlen);
+               process_msg_close(srv_sess, data, datalen, usr, usrlen);
                break;
        case RNBD_MSG_OPEN:
                ret = process_msg_open(srv_sess, usr, usrlen, data, datalen);