scsi: mac53c94: Fix warning comparing pointer to 0

Fix the following coccicheck warning:

./drivers/scsi/mac53c94.c:470:29-30: WARNING comparing pointer to 0.
./drivers/scsi/mac53c94.c:349:12-13: WARNING comparing pointer to 0.

Link: https://lore.kernel.org/r/1615349771-81106-1-git-send-email-jiapeng.chong@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c
index 9e989776609b3be5505a217007502f24677b3b7e..ec9840d322e5c2a11787834cc6f156e4728cf3d0 100644 (file)
--- a/drivers/scsi/mac53c94.c
+++ b/drivers/scsi/mac53c94.c
@@ -346,7 +346,7 @@ static void cmd_done(struct fsc_state *state, int result)
        struct scsi_cmnd *cmd;
 
        cmd = state->current_req;
-       if (cmd != 0) {
+       if (cmd) {
                cmd->result = result;
                (*cmd->scsi_done)(cmd);
                state->current_req = NULL;
@@ -467,12 +467,13 @@ static int mac53c94_probe(struct macio_dev *mdev, const struct of_device_id *mat
                dma_cmd_space = kmalloc_array(host->sg_tablesize + 2,
                                             sizeof(struct dbdma_cmd),
                                             GFP_KERNEL);
-               if (dma_cmd_space == 0) {
-                       printk(KERN_ERR "mac53c94: couldn't allocate dma "
-                              "command space for %pOF\n", node);
+       if (!dma_cmd_space) {
+               printk(KERN_ERR "mac53c94: couldn't allocate dma "
+                      "command space for %pOF\n", node);
                rc = -ENOMEM;
-                       goto out_free;
-               }
+               goto out_free;
+       }
+
        state->dma_cmds = (struct dbdma_cmd *)DBDMA_ALIGN(dma_cmd_space);
        memset(state->dma_cmds, 0, (host->sg_tablesize + 1)
               * sizeof(struct dbdma_cmd));