[CID-1104372] Fix NULL pointer dereference 64/222764/1
authorSeonah Moon <seonah1.moon@samsung.com>
Mon, 20 Jan 2020 01:54:51 +0000 (10:54 +0900)
committerSeonah Moon <seonah1.moon@samsung.com>
Mon, 20 Jan 2020 01:54:54 +0000 (10:54 +0900)
g_dbus_proxy_call_finish() returns NULL if error is set.

Change-Id: I5898e36577999cb5b4cb05b2b523b1f92b965e43

src/tethering.c

index 0a132a76b593d8c95eed9094398250a0409b454e..54da6f1ff208ad327c7143e73b01a8082959b32d 100755 (executable)
@@ -1145,15 +1145,17 @@ static void __settings_reloaded_cb(GObject *source_object, GAsyncResult *res,
                else
                        tethering_error = TETHERING_ERROR_OPERATION_FAILED;
                g_error_free(g_error);
+       } else {
+               g_variant_get(g_var, "(u)", &info);
+               if (tethering_error == TETHERING_ERROR_NONE)
+                       tethering_error = __get_error(info);
+               g_variant_unref(g_var);
        }
+
        if (th->settings_reloaded_cb == NULL) {
                DBG("There is no settings_reloaded_cb\n-\n");
                return;
        }
-       g_variant_get(g_var, "(u)", &info);
-       if (tethering_error == TETHERING_ERROR_NONE)
-               tethering_error = __get_error(info);
-       g_variant_unref(g_var);
 
        th->settings_reloaded_cb(tethering_error,
                        th->settings_reloaded_user_data);