powerpc: fsl_soc: Use of_range_to_resource() for "ranges" parsing
authorRob Herring <robh@kernel.org>
Fri, 9 Jun 2023 18:32:38 +0000 (12:32 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 21 Jun 2023 05:13:56 +0000 (15:13 +1000)
"ranges" is a standard property with common parsing functions. Users
shouldn't be implementing their own parsing of it. Refactor the FSL RapidIO
"ranges" parsing to use of_range_to_resource() instead.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230609183238.1767186-1-robh@kernel.org
arch/powerpc/sysdev/fsl_soc.c

index 6ebbbca..6870974 100644 (file)
@@ -51,18 +51,10 @@ phys_addr_t get_immrbase(void)
 
        soc = of_find_node_by_type(NULL, "soc");
        if (soc) {
-               int size;
-               u32 naddr;
-               const __be32 *prop = of_get_property(soc, "#address-cells", &size);
-
-               if (prop && size == 4)
-                       naddr = be32_to_cpup(prop);
-               else
-                       naddr = 2;
-
-               prop = of_get_property(soc, "ranges", &size);
-               if (prop)
-                       immrbase = of_translate_address(soc, prop + naddr);
+               struct resource res;
+
+               if (!of_range_to_resource(soc, 0, &res))
+                       immrbase = res.start;
 
                of_node_put(soc);
        }