ksmbd: fix wrong error response status by using set_smb2_rsp_status()
authorNamjae Jeon <linkinjeon@kernel.org>
Mon, 9 Oct 2023 14:58:15 +0000 (23:58 +0900)
committerSteve French <stfrench@microsoft.com>
Fri, 13 Oct 2023 03:44:05 +0000 (22:44 -0500)
set_smb2_rsp_status() after __process_request() sets the wrong error
status. This patch resets all iov vectors and sets the error status
on clean one.

Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c

index 898860a..87c6401 100644 (file)
@@ -231,11 +231,12 @@ void set_smb2_rsp_status(struct ksmbd_work *work, __le32 err)
 {
        struct smb2_hdr *rsp_hdr;
 
-       if (work->next_smb2_rcv_hdr_off)
-               rsp_hdr = ksmbd_resp_buf_next(work);
-       else
-               rsp_hdr = smb2_get_msg(work->response_buf);
+       rsp_hdr = smb2_get_msg(work->response_buf);
        rsp_hdr->Status = err;
+
+       work->iov_idx = 0;
+       work->iov_cnt = 0;
+       work->next_smb2_rcv_hdr_off = 0;
        smb2_set_err_rsp(work);
 }