ELF64: We apparently don't need exactitude for GOTOFF64
authorH. Peter Anvin <hpa@zytor.com>
Sat, 18 Oct 2008 05:11:20 +0000 (22:11 -0700)
committerH. Peter Anvin <hpa@zytor.com>
Sat, 18 Oct 2008 05:11:20 +0000 (22:11 -0700)
I am having a bit of a hard time understanding the proper operation of
the "exact" flag to elf_add_gsym_reloc().  We apparently won't
generate proper GOTOFF64 relocations with this flag set; it is
possible that there are *no* proper uses of this flag.  This clearly
needs to be figured out.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
output/outelf64.c

index 3e9f7767b7f374435a62860198e55bc7ac823fad..1405d2fdd6f13f79e45ad8a39210c831794d3c44 100644 (file)
@@ -1013,7 +1013,7 @@ static void elf_out(int32_t segto, const void *data,
                          "references to be qword absolute");
                } else {
                    elf_add_gsym_reloc(s, segment, addr, 0,
-                                      R_X86_64_GOTOFF64, true);
+                                      R_X86_64_GOTOFF64, false);
                    addr = 0;
                }
            } else if (wrt == elf_got_sect + 1) {