coresight: Remove obsolete Trace ID unniqueness checks

The checks for sources to have unique IDs has been removed - this is now
guaranteed by the ID allocation mechanisms, and inappropriate where
multiple ID maps are in use in larger systems

Signed-off-by: Mike Leach <mike.leach@linaro.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20230116124928.5440-3-mike.leach@linaro.org

diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index f306817..ce3aa84 100644 (file)
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -112,45 +112,6 @@ struct coresight_device *coresight_get_percpu_sink(int cpu)
 }
 EXPORT_SYMBOL_GPL(coresight_get_percpu_sink);
 
-static int coresight_id_match(struct device *dev, void *data)
-{
-       int trace_id, i_trace_id;
-       struct coresight_device *csdev, *i_csdev;
-
-       csdev = data;
-       i_csdev = to_coresight_device(dev);
-
-       /*
-        * No need to care about oneself and components that are not
-        * sources or not enabled
-        */
-       if (i_csdev == csdev || !i_csdev->enable ||
-           i_csdev->type != CORESIGHT_DEV_TYPE_SOURCE)
-               return 0;
-
-       /* Get the source ID for both components */
-       trace_id = source_ops(csdev)->trace_id(csdev);
-       i_trace_id = source_ops(i_csdev)->trace_id(i_csdev);
-
-       /* All you need is one */
-       if (trace_id == i_trace_id)
-               return 1;
-
-       return 0;
-}
-
-static int coresight_source_is_unique(struct coresight_device *csdev)
-{
-       int trace_id = source_ops(csdev)->trace_id(csdev);
-
-       /* this shouldn't happen */
-       if (trace_id < 0)
-               return 0;
-
-       return !bus_for_each_dev(&coresight_bustype, NULL,
-                                csdev, coresight_id_match);
-}
-
 static int coresight_find_link_inport(struct coresight_device *csdev,
                                      struct coresight_device *parent)
 {
@@ -459,12 +420,6 @@ static int coresight_enable_source(struct coresight_device *csdev, u32 mode)
 {
        int ret;
 
-       if (!coresight_source_is_unique(csdev)) {
-               dev_warn(&csdev->dev, "traceID %d not unique\n",
-                        source_ops(csdev)->trace_id(csdev));
-               return -EINVAL;
-       }
-
        if (!csdev->enable) {
                if (source_ops(csdev)->enable) {
                        ret = coresight_control_assoc_ectdev(csdev, true);