gpio: omap: improve coding style for pin config flags

Change the handling of pin config flags from if/else to switch
statement to make the code more readable and cleaner.

Suggested-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20200722120755.230741-1-drew@beagleboard.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index e0eada8..7fbe0c9 100644 (file)
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -899,13 +899,18 @@ static int omap_gpio_set_config(struct gpio_chip *chip, unsigned offset,
        u32 debounce;
        int ret = -ENOTSUPP;
 
-       if ((pinconf_to_config_param(config) == PIN_CONFIG_BIAS_DISABLE) ||
-           (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_UP) ||
-           (pinconf_to_config_param(config) == PIN_CONFIG_BIAS_PULL_DOWN)) {
+       switch (pinconf_to_config_param(config)) {
+       case PIN_CONFIG_BIAS_DISABLE:
+       case PIN_CONFIG_BIAS_PULL_UP:
+       case PIN_CONFIG_BIAS_PULL_DOWN:
                ret = gpiochip_generic_config(chip, offset, config);
-       } else if (pinconf_to_config_param(config) == PIN_CONFIG_INPUT_DEBOUNCE) {
+               break;
+       case PIN_CONFIG_INPUT_DEBOUNCE:
                debounce = pinconf_to_config_argument(config);
                ret = omap_gpio_debounce(chip, offset, debounce);
+               break;
+       default:
+               break;
        }
 
        return ret;