net: ksz884x: fix missing pci_disable_device() on error in pcidev_init()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 24 Oct 2022 13:13:38 +0000 (21:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:59:18 +0000 (23:59 +0900)
[ Upstream commit 5da6d65590a0698199df44d095e54b0ed1708178 ]

pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release()
while unbinding device.

Fixes: 8ca86fd83eae ("net: Micrel KSZ8841/2 PCI Ethernet driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221024131338.2848959-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/micrel/ksz884x.c

index a0ee155..f56bcd3 100644 (file)
@@ -6848,7 +6848,7 @@ static int pcidev_init(struct pci_dev *pdev, const struct pci_device_id *id)
        char banner[sizeof(version)];
        struct ksz_switch *sw = NULL;
 
-       result = pci_enable_device(pdev);
+       result = pcim_enable_device(pdev);
        if (result)
                return result;