phy: qcom: qmp-usb: fix NULL-deref on runtime suspend
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 11 Sep 2024 11:52:50 +0000 (13:52 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 17 Oct 2024 13:03:46 +0000 (18:33 +0530)
Commit 413db06c05e7 ("phy: qcom-qmp-usb: clean up probe initialisation")
removed most users of the platform device driver data, but mistakenly
also removed the initialisation despite the data still being used in the
runtime PM callbacks.

Restore the driver data initialisation at probe to avoid a NULL-pointer
dereference on runtime suspend.

Apparently no one uses runtime PM, which currently needs to be enabled
manually through sysfs, with this driver.

Fixes: 413db06c05e7 ("phy: qcom-qmp-usb: clean up probe initialisation")
Cc: stable@vger.kernel.org # 6.2
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240911115253.10920-2-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-usb.c

index 2fd49355aa37645d99e49ea521b3770c4540c732..1246d3bc8b92f8727867208ee85cf937bc0d1fd2 100644 (file)
@@ -2179,6 +2179,7 @@ static int qmp_usb_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        qmp->dev = dev;
+       dev_set_drvdata(dev, qmp);
 
        qmp->cfg = of_device_get_match_data(dev);
        if (!qmp->cfg)