mmc: sdhci: Remove misleading comment about resets
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 26 Sep 2022 19:20:20 +0000 (22:20 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 28 Sep 2022 08:08:41 +0000 (10:08 +0200)
In SDHCI specification section 3.10.1 Error Interrupt Recovery, the flow
chart shows Software Reset for CMD separately and before Software Reset for
DAT, so the comment "Spec says we should do both at the same time" is not
correct. Remove it.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20220926192022.85660-3-adrian.hunter@intel.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci.c

index a20123d..4d672e7 100644 (file)
@@ -3063,10 +3063,6 @@ static bool sdhci_request_done(struct sdhci_host *host)
                        /* This is to force an update */
                        host->ops->set_clock(host, host->clock);
 
-               /*
-                * Spec says we should do both at the same time, but Ricoh
-                * controllers do not like that.
-                */
                sdhci_do_reset(host, SDHCI_RESET_CMD);
                sdhci_do_reset(host, SDHCI_RESET_DATA);