drm/i915: Skip cursor when writing PLANE_CHICKEN
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 29 Mar 2023 19:04:43 +0000 (22:04 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 31 Mar 2023 11:58:01 +0000 (14:58 +0300)
Cursor is not a universal plane and thus doesn't have the
PLANE_CHICKEN register. Skip it.

Fixes: c5de248484af ("drm/i915/dpt: Add a modparam to disable DPT via the chicken bit")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230329190445.13456-1-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/display/intel_dpt.c

index 2bf5cce..b802739 100644 (file)
@@ -324,10 +324,14 @@ void intel_dpt_configure(struct intel_crtc *crtc)
                enum pipe pipe = crtc->pipe;
                enum plane_id plane_id;
 
-               for_each_plane_id_on_crtc(crtc, plane_id)
+               for_each_plane_id_on_crtc(crtc, plane_id) {
+                       if (plane_id == PLANE_CURSOR)
+                               continue;
+
                        intel_de_rmw(i915, PLANE_CHICKEN(pipe, plane_id),
                                     PLANE_CHICKEN_DISABLE_DPT,
                                     i915->params.enable_dpt ? 0 : PLANE_CHICKEN_DISABLE_DPT);
+               }
        } else if (DISPLAY_VER(i915) == 13) {
                intel_de_rmw(i915, CHICKEN_MISC_2,
                             CHICKEN_MISC_DISABLE_DPT,