A64: Restore the stack limit protection to 1KB.
authoralexandre.rames@arm.com <alexandre.rames@arm.com@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Thu, 20 Mar 2014 15:25:27 +0000 (15:25 +0000)
committeralexandre.rames@arm.com <alexandre.rames@arm.com@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Thu, 20 Mar 2014 15:25:27 +0000 (15:25 +0000)
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/a64/simulator-a64.cc
src/a64/simulator-a64.h

index d414bf5426e3c83ba509effb5c1f8d342d17d0d8..a401c62d2ebdf6d287b3c265a8c5ef56d92a171f 100644 (file)
@@ -359,12 +359,7 @@ uintptr_t Simulator::PopAddress() {
 uintptr_t Simulator::StackLimit() const {
   // Leave a safety margin of 1024 bytes to prevent overrunning the stack when
   // pushing values.
-  // TODO(all): Increase the stack limit protection.
-
-  // The margin was decreased to 256 bytes, because we are intensively using
-  // the stack. The stack usage should decrease when our code improves. Then
-  // we can set it to 1024 again.
-  return reinterpret_cast<uintptr_t>(stack_limit_) + 256;
+  return reinterpret_cast<uintptr_t>(stack_limit_) + 1024;
 }
 
 
index 0d973e835e14bbb8f58a963c25909c7683d63c2a..1ef891a151ecee375870f5e6073f01cc93d1d773 100644 (file)
@@ -833,7 +833,6 @@ class Simulator : public DecoderVisitor {
   static const intptr_t stack_protection_size_ = KB;
   intptr_t stack_size_;
   byte* stack_limit_;
-  // TODO(aleram): protect the stack.
 
   Decoder<DispatchingDecoderVisitor>* decoder_;
   Decoder<DispatchingDecoderVisitor>* disassembler_decoder_;