e_hints: change return value of e_hints_aux_hint_add_with_pixmap 46/208746/2
authorDoyoun Kang <doyoun.kang@samsung.com>
Thu, 27 Jun 2019 11:46:49 +0000 (20:46 +0900)
committerDoyoun Kang <doyoun.kang@samsung.com>
Mon, 1 Jul 2019 01:04:51 +0000 (01:04 +0000)
We changed the return value of e_hints_aux_hint_add_with_pixmap() to true
if the aux hint id was already exist.

Change-Id: I91a321c5b820faf348679e60ec74a27ac9a9086e

src/bin/e_hints.c

index d82cef4b0c42b89ab6047e0270866e2de3b232ce..2d56dded23780a2a05b76660077e7566ff481930 100644 (file)
@@ -281,10 +281,10 @@ e_hints_aux_hint_add_with_pixmap(E_Pixmap *cp, int32_t id, const char *name, con
                         e_pixmap_client_get(cp),
                         id, hint->hint, hint->val, val);
                   eina_stringshare_del(hint->val);
+
                   hint->val = eina_stringshare_add(val);
                   hint->changed = EINA_TRUE;
-                  if (hint->deleted)
-                    hint->deleted = EINA_FALSE;
+                  hint->deleted = EINA_FALSE;
                   cdata->aux_hint.changed = 1;
                }
              found = EINA_TRUE;
@@ -310,10 +310,7 @@ e_hints_aux_hint_add_with_pixmap(E_Pixmap *cp, int32_t id, const char *name, con
               id, hint->hint, hint->val);
      }
 
-   if (!found)
-     return EINA_TRUE;
-
-   return EINA_FALSE;
+   return EINA_TRUE;
 }
 
 E_API Eina_Bool