btrfs: remove the unnecessary result variables
authorzhang songyi <zhang.songyi@zte.com.cn>
Fri, 2 Sep 2022 15:40:29 +0000 (15:40 +0000)
committerDavid Sterba <dsterba@suse.com>
Mon, 26 Sep 2022 10:28:00 +0000 (12:28 +0200)
Return the sysfs_emit() and iterate_object_props() directly instead of
using unnecessary variables.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/props.c
fs/btrfs/sysfs.c

index a2ec8ec..055a631 100644 (file)
@@ -270,11 +270,8 @@ int btrfs_load_inode_props(struct inode *inode, struct btrfs_path *path)
 {
        struct btrfs_root *root = BTRFS_I(inode)->root;
        u64 ino = btrfs_ino(BTRFS_I(inode));
-       int ret;
-
-       ret = iterate_object_props(root, path, ino, inode_prop_iterator, inode);
 
-       return ret;
+       return iterate_object_props(root, path, ino, inode_prop_iterator, inode);
 }
 
 static int prop_compression_validate(const struct btrfs_inode *inode,
index 6816bc4..ed3fbfd 100644 (file)
@@ -839,11 +839,8 @@ static ssize_t btrfs_sinfo_bg_reclaim_threshold_show(struct kobject *kobj,
                                                     char *buf)
 {
        struct btrfs_space_info *space_info = to_space_info(kobj);
-       ssize_t ret;
-
-       ret = sysfs_emit(buf, "%d\n", READ_ONCE(space_info->bg_reclaim_threshold));
 
-       return ret;
+       return sysfs_emit(buf, "%d\n", READ_ONCE(space_info->bg_reclaim_threshold));
 }
 
 static ssize_t btrfs_sinfo_bg_reclaim_threshold_store(struct kobject *kobj,
@@ -1205,11 +1202,8 @@ static ssize_t btrfs_bg_reclaim_threshold_show(struct kobject *kobj,
                                               char *buf)
 {
        struct btrfs_fs_info *fs_info = to_fs_info(kobj);
-       ssize_t ret;
-
-       ret = sysfs_emit(buf, "%d\n", READ_ONCE(fs_info->bg_reclaim_threshold));
 
-       return ret;
+       return sysfs_emit(buf, "%d\n", READ_ONCE(fs_info->bg_reclaim_threshold));
 }
 
 static ssize_t btrfs_bg_reclaim_threshold_store(struct kobject *kobj,