Change error check order 83/229783/3
authorSeungha Son <seungha.son@samsung.com>
Fri, 3 Apr 2020 08:35:27 +0000 (17:35 +0900)
committerSeungha Son <seungha.son@samsung.com>
Mon, 6 Apr 2020 02:01:01 +0000 (11:01 +0900)
Change-Id: I0bc2f11b1dff501b8dcfc84bbbad166a8a5d1b64
Signed-off-by: Seungha Son <seungha.son@samsung.com>
src/atrace/atrace.cpp

index dea5d0a2b2c47824913279297924e62864df361d..81ea9d8fa2caaa0e3cf4ca3bb5bc1e266749a7af 100755 (executable)
@@ -687,28 +687,25 @@ static void stopTrace()
 static void dumpTrace(bool startup)
 {
     int backup_fd = -1;
-    int traceFD = open(k_tracePath, O_RDWR);
+    int traceFD = -1;
+
+    traceFD = open(k_tracePath, O_RDWR);
+    if (traceFD == -1) {
+        fprintf(stderr, "error opening %s: %s (%d)\n", k_tracePath,
+                strerror_r(errno, str_error, sizeof(str_error)), errno);
+        return;
+    }
 
     if(startup) {
         backup_fd = open(BACKUP_TRACE, O_CREAT|O_RDWR|O_TRUNC, 0600);
-
         if (backup_fd == -1) {
             fprintf(stderr, "error opening %s: %s (%d)\n", BACKUP_TRACE,
                     strerror_r(errno, str_error, sizeof(str_error)), errno);
-            if (traceFD > -1)
-                close(traceFD);
+            close(traceFD);
             return;
         }
     }
 
-    if (traceFD == -1) {
-        fprintf(stderr, "error opening %s: %s (%d)\n", k_tracePath,
-                strerror_r(errno, str_error, sizeof(str_error)), errno);
-        if (backup_fd > -1)
-            close(backup_fd);
-        return;
-    }
-
     if (g_compress) {
         z_stream zs;
         uint8_t *in, *out;