gst/audiofxgood/audiopanorama.c: Fix docs & debug category. Add Fixme for volume...

Original commit message from CVS:
* gst/audiofxgood/audiopanorama.c:
(gst_audio_panorama_transform_m2s):
Fix docs & debug category. Add Fixme for volume pan levels.

diff --git a/ChangeLog b/ChangeLog
index 6b168d3e358dbd7b7c509de6847b4ba8eb85c847..11ab3a945223a4669f84c4ae90edf5eb3553494e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2006-08-24  Stefan Kost  <ensonic@users.sf.net>
+
+       * gst/audiofxgood/audiopanorama.c:
+       (gst_audio_panorama_transform_m2s):
+         Fix docs & debug category. Add Fixme for volume pan levels.
+
 2006-08-24  Stefan Kost  <ensonic@users.sf.net>
 
        * gst/avi/gstavidemux.c: (gst_avi_demux_read_subindexes_pull),

diff --git a/gst/audiofx/audiopanorama.c b/gst/audiofx/audiopanorama.c
index 760f6ed02955278cb28063838bc61592d80bf679..4bf209d7e8c16f52a57f9acefcfe3daec23de7ec 100644 (file)
--- a/gst/audiofx/audiopanorama.c
+++ b/gst/audiofx/audiopanorama.c
@@ -23,15 +23,13 @@
  * @short_description: audio strereo pan effect
  *
  * <refsect2>
- * Echo effect with controllable effect-ratio, delay-time and feedback.
+ * Stereo panorama effect with controllable pan position.
  * <title>Example launch line</title>
  * <para>
  * <programlisting>
  * gst-launch audiotestsrc wave=saw ! audiopanorama panorama=-100 ! alsasink
  * gst-launch filesrc location="melo1.ogg" ! oggdemux ! vorbisdec ! audioconvert ! audiopanorama panorama=-100 ! alsasink
  * </programlisting>
- * In the latter example the echo is applied to the input signal of the
- * soundcard (like a microphone).
  * </para>
  * </refsect2>
  */
@@ -91,7 +89,7 @@ static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src",
     );
 
 #define DEBUG_INIT(bla) \
-  GST_DEBUG_CATEGORY_INIT (gst_audio_panorama_debug, "audiopanorama", 0, "audiopanorama plugin");
+  GST_DEBUG_CATEGORY_INIT (gst_audio_panorama_debug, "audiopanorama", 0, "audiopanorama element");
 
 GST_BOILERPLATE_FULL (GstAudioPanorama, gst_audio_panorama, GstBaseTransform,
     GST_TYPE_BASE_TRANSFORM, DEBUG_INIT);
@@ -289,6 +287,8 @@ gst_audio_panorama_transform_m2s (GstAudioPanorama * filter, gint16 * idata,
   /* pan:  -100   0   100
    * lpan:  1.0  0.5  0.0  
    * rpan:  0.0  0.5  1.0
+   *
+   * FIXME: we should use -3db (1/sqtr(2)) for 50:50
    */
   rpan = (gdouble) (filter->panorama + 100) / 200.0;
   lpan = 1.0 - rpan;

diff --git a/gst/audiofxgood/audiopanorama.c b/gst/audiofxgood/audiopanorama.c
index 760f6ed02955278cb28063838bc61592d80bf679..4bf209d7e8c16f52a57f9acefcfe3daec23de7ec 100644 (file)
--- a/gst/audiofxgood/audiopanorama.c
+++ b/gst/audiofxgood/audiopanorama.c
@@ -23,15 +23,13 @@
  * @short_description: audio strereo pan effect
  *
  * <refsect2>
- * Echo effect with controllable effect-ratio, delay-time and feedback.
+ * Stereo panorama effect with controllable pan position.
  * <title>Example launch line</title>
  * <para>
  * <programlisting>
  * gst-launch audiotestsrc wave=saw ! audiopanorama panorama=-100 ! alsasink
  * gst-launch filesrc location="melo1.ogg" ! oggdemux ! vorbisdec ! audioconvert ! audiopanorama panorama=-100 ! alsasink
  * </programlisting>
- * In the latter example the echo is applied to the input signal of the
- * soundcard (like a microphone).
  * </para>
  * </refsect2>
  */
@@ -91,7 +89,7 @@ static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src",
     );
 
 #define DEBUG_INIT(bla) \
-  GST_DEBUG_CATEGORY_INIT (gst_audio_panorama_debug, "audiopanorama", 0, "audiopanorama plugin");
+  GST_DEBUG_CATEGORY_INIT (gst_audio_panorama_debug, "audiopanorama", 0, "audiopanorama element");
 
 GST_BOILERPLATE_FULL (GstAudioPanorama, gst_audio_panorama, GstBaseTransform,
     GST_TYPE_BASE_TRANSFORM, DEBUG_INIT);
@@ -289,6 +287,8 @@ gst_audio_panorama_transform_m2s (GstAudioPanorama * filter, gint16 * idata,
   /* pan:  -100   0   100
    * lpan:  1.0  0.5  0.0  
    * rpan:  0.0  0.5  1.0
+   *
+   * FIXME: we should use -3db (1/sqtr(2)) for 50:50
    */
   rpan = (gdouble) (filter->panorama + 100) / 200.0;
   lpan = 1.0 - rpan;