media: cec: cec_transmit_attempt_done: ignore CEC_TX_STATUS_MAX_RETRIES
authorHans Verkuil <hverkuil@xs4all.nl>
Wed, 12 Jul 2017 20:07:08 +0000 (17:07 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 26 Jul 2017 09:46:43 +0000 (05:46 -0400)
The switch in cec_transmit_attempt_done() should ignore the
CEC_TX_STATUS_MAX_RETRIES status bit.

Calling this function with e.g. CEC_TX_STATUS_NACK | CEC_TX_STATUS_MAX_RETRIES
is perfectly legal and should not trigger the WARN(1).

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/cec/cec-adap.c

index bf45977..d596b60 100644 (file)
@@ -559,7 +559,7 @@ EXPORT_SYMBOL_GPL(cec_transmit_done);
 
 void cec_transmit_attempt_done(struct cec_adapter *adap, u8 status)
 {
-       switch (status) {
+       switch (status & ~CEC_TX_STATUS_MAX_RETRIES) {
        case CEC_TX_STATUS_OK:
                cec_transmit_done(adap, status, 0, 0, 0, 0);
                return;