Mandatorily check signature verification
authorDuyoung Jang <duyoung.jang@samsung.com>
Tue, 27 Aug 2013 04:50:20 +0000 (13:50 +0900)
committerDuyoung Jang <duyoung.jang@samsung.com>
Tue, 27 Aug 2013 04:50:20 +0000 (13:50 +0900)
Change-Id: I287d9075c342a28c32f9b3df0cdcc4435a71cc7a
Signed-off-by: Duyoung Jang <duyoung.jang@samsung.com>
inc/InstallerDefs.h
src/Context/InstallationContext.cpp
src/Installer/DirectoryInstaller.cpp
src/Step/PackageCheckStep.cpp

index 8ef969e..6290ade 100755 (executable)
@@ -23,7 +23,7 @@
 
 #include "InstallerUtil.h"
 
-#define OSP_INSTALLER_VERSION "version=[20130826.3]"
+#define OSP_INSTALLER_VERSION "version=[20130827.1]"
 
 #define DIR_BIN                                L"/bin"
 #define DIR_INFO                       L"/info"
index c4efb1a..1066c8f 100755 (executable)
@@ -49,7 +49,7 @@ InstallationContext::InstallationContext(void)
 ,__isOspCompat(false)
 ,__isPreloaded(false)
 ,__isHybridService(false)
-,__isVerificationMode(false)
+,__isVerificationMode(true)
 ,__isUpdated(false)
 ,__isAppSetting(false)
 ,__isCsc(false)
index d0a2b9b..0a13956 100755 (executable)
@@ -72,12 +72,15 @@ DirectoryInstaller::OnInit(void)
 {
        InstallationContext* pContext = GetContext();
 
-       if ((File::IsFileExist(pContext->GetSignatureXmlPath()) == true) &&
-                       (File::IsFileExist(pContext->GetAuthorSignatureXmlPath()) == true) &&
-                       (pContext->__isHybridService == false))
+       if (pContext->__isHybridService == true)
        {
-               AppLog("[VerifySignature] VerificationMode ON");
-               pContext->__isVerificationMode = true;
+               AppLog("[VerifySignature] VerificationMode OFF");
+               pContext->__isVerificationMode = false;
+       }
+       else
+       {
+               TryReturn(File::IsFileExist(pContext->GetAuthorSignatureXmlPath()) == true, INSTALLER_ERROR_PACKAGE_INVALID, "no author-signature.xml");
+               TryReturn(File::IsFileExist(pContext->GetSignatureXmlPath()) == true, INSTALLER_ERROR_PACKAGE_INVALID, "no signature1.xml");
        }
 
        String installPath = pContext->__installDir;
index ecd9c45..4b00ddb 100755 (executable)
@@ -141,20 +141,13 @@ PackageCheckStep::OnStatePackageCheck(void)
        TryReturn(!IsFailed(r), INSTALLER_ERROR_PACKAGE_INVALID, "UnzipTo(manifest.xml) failed.");
 
        r = unzipper.UnzipTo(tempDir, L"signature1.xml");
-       //TryReturn(!IsFailed(r), INSTALLER_ERROR_PACKAGE_INVALID, "UnzipTo(signature1.xml) failed.");
+       TryReturn(!IsFailed(r), INSTALLER_ERROR_PACKAGE_INVALID, "UnzipTo(signature1.xml) failed.");
 
        r = unzipper.UnzipTo(tempDir, L"author-signature.xml");
-       //TryReturn(!IsFailed(r), INSTALLER_ERROR_PACKAGE_INVALID, "UnzipTo(author-signature.xml) failed.");
+       TryReturn(!IsFailed(r), INSTALLER_ERROR_PACKAGE_INVALID, "UnzipTo(author-signature.xml) failed.");
 
        AppLog("UnzipTo(manifest.xml) - END");
 
-       if ((File::IsFileExist(__pContext->GetSignatureXmlPath()) == true) &&
-                       (File::IsFileExist(__pContext->GetAuthorSignatureXmlPath()) == true))
-       {
-               AppLog("[VerifySignature] VerificationMode ON");
-               __pContext->__isVerificationMode = true;
-       }
-
        GoNextState();
        return error;
 }