drm/mxsfb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert the mxsfb driver from always returning zero in the
remove callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-33-u.kleine-koenig@pengutronix.de

diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
index c9d8cbb214079d8b969103b6376f1e03eb356146..9f4212f54af760f539fbd40d85b66317c0e2f50d 100644 (file)
--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
@@ -285,7 +285,7 @@ err_free:
        return ret;
 }
 
-static int lcdif_remove(struct platform_device *pdev)
+static void lcdif_remove(struct platform_device *pdev)
 {
        struct drm_device *drm = platform_get_drvdata(pdev);
 
@@ -293,8 +293,6 @@ static int lcdif_remove(struct platform_device *pdev)
        drm_atomic_helper_shutdown(drm);
        lcdif_unload(drm);
        drm_dev_put(drm);
-
-       return 0;
 }
 
 static void lcdif_shutdown(struct platform_device *pdev)
@@ -362,7 +360,7 @@ static const struct dev_pm_ops lcdif_pm_ops = {
 
 static struct platform_driver lcdif_platform_driver = {
        .probe          = lcdif_probe,
-       .remove         = lcdif_remove,
+       .remove_new     = lcdif_remove,
        .shutdown       = lcdif_shutdown,
        .driver = {
                .name           = "imx-lcdif",

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 368b1fbd8305b3c77a5c867d99d41200f93b9ee7..625c1bfc41733b23e05de4556e3c9841094f7922 100644 (file)
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -377,7 +377,7 @@ err_free:
        return ret;
 }
 
-static int mxsfb_remove(struct platform_device *pdev)
+static void mxsfb_remove(struct platform_device *pdev)
 {
        struct drm_device *drm = platform_get_drvdata(pdev);
 
@@ -385,8 +385,6 @@ static int mxsfb_remove(struct platform_device *pdev)
        drm_atomic_helper_shutdown(drm);
        mxsfb_unload(drm);
        drm_dev_put(drm);
-
-       return 0;
 }
 
 static void mxsfb_shutdown(struct platform_device *pdev)
@@ -418,7 +416,7 @@ static const struct dev_pm_ops mxsfb_pm_ops = {
 
 static struct platform_driver mxsfb_platform_driver = {
        .probe          = mxsfb_probe,
-       .remove         = mxsfb_remove,
+       .remove_new     = mxsfb_remove,
        .shutdown       = mxsfb_shutdown,
        .driver = {
                .name           = "mxsfb",