arm64: dts: exynos: fix polarity of "enable" line of NFC chip in TM2
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Sep 2022 01:15:55 +0000 (18:15 -0700)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 30 Sep 2022 12:23:33 +0000 (14:23 +0200)
According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
when chip is in use.

s3fwrn5_phy_power_ctrl():

...
gpio_set_value(phy->gpio_en, 1);
...
if (mode != S3FWRN5_MODE_COLD) {
msleep(S3FWRN5_EN_WAIT_TIME);
gpio_set_value(phy->gpio_en, 0);
msleep(S3FWRN5_EN_WAIT_TIME);
}

Therefore the line described by "en-gpios" property should be annotated
as "active low".

The wakeup gpio appears to have correct polarity (active high).

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://lore.kernel.org/r/20220929011557.4165216-1-dmitry.torokhov@gmail.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi

index 91c9bd1..bde6a6b 100644 (file)
                reg = <0x27>;
                interrupt-parent = <&gpa1>;
                interrupts = <3 IRQ_TYPE_EDGE_RISING>;
-               en-gpios = <&gpf1 4 GPIO_ACTIVE_HIGH>;
+               en-gpios = <&gpf1 4 GPIO_ACTIVE_LOW>;
                wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
        };
 };