Revert revisions 3013, 3014, and 3016. We need a better solution.

Review URL: http://codereview.chromium.org/251088

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3017 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/include/v8.h b/include/v8.h
index 6d9370f59909a00c49d3311182626caf9a7dec15..4992d75542c030641ef8a6df86d1a473c48a717c 100644 (file)
--- a/include/v8.h
+++ b/include/v8.h
@@ -1063,7 +1063,6 @@ class V8EXPORT Number : public Primitive {
 class V8EXPORT Integer : public Number {
  public:
   static Local<Integer> New(int32_t value);
-  static inline Local<Integer> New(uint32_t value);
   int64_t Value() const;
   static inline Integer* Cast(v8::Value* obj);
  private:
@@ -3027,16 +3026,6 @@ Number* Number::Cast(v8::Value* value) {
 }
 
 
-Local<Integer> Integer::New(uint32_t value) {
-  // If highest bit is not set, chances are it's SMI.
-  bool could_be_smi = (value & (1 << 31)) == 0;
-  if (could_be_smi) {
-    return Integer::New(static_cast<int32_t>(value));
-  }
-  return Local<Integer>::Cast(Number::New(value));
-}
-
-
 Integer* Integer::Cast(v8::Value* value) {
 #ifdef V8_ENABLE_CHECKS
   CheckCast(value);

diff --git a/src/checks.h b/src/checks.h
index 74d15212dd2063c44c7fa7b6468733545461586c..b302e5beee04da3c02604d6357ab2a0f8c610358 100644 (file)
--- a/src/checks.h
+++ b/src/checks.h
@@ -80,27 +80,6 @@ static inline void CheckEqualsHelper(const char* file, int line,
   }
 }
 
-// Helper function used by the CHECK_INT64_EQ function when given int64_t
-// arguments.  Should not be called directly.  We do not overload CHECK_EQ
-// with both 32-bit and 64-bit integers, because it causes ambiguity
-// with operands of mixed sizes.
-static inline void CheckInt64EqualsHelper(const char* file, int line,
-                                          const char* expected_source,
-                                          int64_t expected,
-                                          const char* value_source,
-                                          int64_t value) {
-  if (expected != value) {
-    // Print int64_t values in hex, as two int32s,
-    // to avoid platform-dependencies.
-    V8_Fatal(file, line,
-             "CHECK_EQ(%s, %s) failed\n#"
-             "   Expected: 0x%08x%08x\n#   Found: 0x%08x%08x",
-             expected_source, value_source,
-             uint32_t(expected >> 32), uint32_t(expected),
-             uint32_t(value >> 32), uint32_t(value));
-  }
-}
-
 
 // Helper function used by the CHECK_NE function when given int
 // arguments.  Should not be called directly.
@@ -233,9 +212,6 @@ void CheckEqualsHelper(const char* file,
 #define CHECK_GT(a, b) CHECK((a) > (b))
 #define CHECK_GE(a, b) CHECK((a) >= (b))
 
-#define CHECK_INT64_EQ(expected, value) CheckInt64EqualsHelper(__FILE__, \
-  __LINE__, #expected, expected, #value, value)
-
 
 // This is inspired by the static assertion facility in boost.  This
 // is pretty magical.  If it causes you trouble on a platform you may

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 0e4b5b1717c7447edc8679e838f13b68f3ea801c..f430cbde03802869c48961d9790008f5c551335f 100644 (file)
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -702,75 +702,6 @@ THREADED_TEST(PropertyHandler) {
 }
 
 
-THREADED_TEST(TinyInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  int32_t value = 239;
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
-THREADED_TEST(BigSmiInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  int32_t value = (1 << 30) - 1;
-  CHECK(i::Smi::IsValid(value));
-  CHECK(!i::Smi::IsValid(value + 1));
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
-THREADED_TEST(BigInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  int32_t value = (1 << 30) + 1;
-  CHECK(!i::Smi::IsValid(value));
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
-THREADED_TEST(TinyUnsignedInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  uint32_t value = 239;
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
-THREADED_TEST(BigUnsignedSmiInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  uint32_t value = (1 << 30) - 1;
-  CHECK(i::Smi::IsValid(value));
-  CHECK(!i::Smi::IsValid(value + 1));
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
-THREADED_TEST(BigUnsignedInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  uint32_t value = (1 << 30) + 1;
-  CHECK(!i::Smi::IsValid(value));
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
-THREADED_TEST(OutOfSignedRangeUnsignedInteger) {
-  v8::HandleScope scope;
-  LocalContext env;
-  uint32_t value = uint32_t(0xffffffff);
-  Local<v8::Integer> value_obj = v8::Integer::New(value);
-  CHECK_INT64_EQ(static_cast<int64_t>(value), value_obj->Value());
-}
-
-
 THREADED_TEST(Number) {
   v8::HandleScope scope;
   LocalContext env;