V4L/DVB (12435): strlcpy() will always null terminate the string.
authorRoel Kluin <roel.kluin@gmail.com>
Sat, 8 Aug 2009 15:58:52 +0000 (12:58 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 12 Sep 2009 15:18:50 +0000 (12:18 -0300)
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/dvb-usb/dvb-usb-i2c.c
drivers/media/video/pwc/pwc-v4l.c
drivers/media/video/zoran/zoran_card.c

index 326f760..cead089 100644 (file)
@@ -19,7 +19,7 @@ int dvb_usb_i2c_init(struct dvb_usb_device *d)
                return -EINVAL;
        }
 
-       strncpy(d->i2c_adap.name, d->desc->name, sizeof(d->i2c_adap.name));
+       strlcpy(d->i2c_adap.name, d->desc->name, sizeof(d->i2c_adap.name));
        d->i2c_adap.class = I2C_CLASS_TV_DIGITAL,
        d->i2c_adap.algo      = d->props.i2c_algo;
        d->i2c_adap.algo_data = NULL;
index 2876ce0..bdb4ced 100644 (file)
@@ -1033,7 +1033,7 @@ long pwc_video_do_ioctl(struct file *file, unsigned int cmd, void *arg)
                        if (std->index != 0)
                                return -EINVAL;
                        std->id = V4L2_STD_UNKNOWN;
-                       strncpy(std->name, "webcam", sizeof(std->name));
+                       strlcpy(std->name, "webcam", sizeof(std->name));
                        return 0;
                }
 
index 40d07fa..0c4d9b1 100644 (file)
@@ -1168,7 +1168,7 @@ zoran_setup_videocodec (struct zoran *zr,
        m->type = 0;
 
        m->flags = CODEC_FLAG_ENCODER | CODEC_FLAG_DECODER;
-       strncpy(m->name, ZR_DEVNAME(zr), sizeof(m->name));
+       strlcpy(m->name, ZR_DEVNAME(zr), sizeof(m->name));
        m->data = zr;
 
        switch (type)