drm/amd/display: Add return code instead of boolean for future use
authorFangzhi Zuo <Jerry.Zuo@amd.com>
Tue, 19 Jan 2021 21:52:57 +0000 (16:52 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 9 Feb 2021 20:30:32 +0000 (15:30 -0500)
Signed-off-by: Fangzhi Zuo <Jerry.Zuo@amd.com>
Reviewed-by: Mikita Lipski <Mikita.Lipski@amd.com>
Acked-by: Anson Jacob <Anson.Jacob@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

index 3244a6e..5159399 100644 (file)
@@ -526,11 +526,11 @@ bool dm_helpers_submit_i2c(
 bool dm_helpers_dp_write_dsc_enable(
                struct dc_context *ctx,
                const struct dc_stream_state *stream,
-               bool enable
-)
+               bool enable)
 {
        uint8_t enable_dsc = enable ? 1 : 0;
        struct amdgpu_dm_connector *aconnector;
+       uint8_t ret;
 
        if (!stream)
                return false;
@@ -541,13 +541,13 @@ bool dm_helpers_dp_write_dsc_enable(
                if (!aconnector->dsc_aux)
                        return false;
 
-               return (drm_dp_dpcd_write(aconnector->dsc_aux, DP_DSC_ENABLE, &enable_dsc, 1) >= 0);
+               ret = drm_dp_dpcd_write(aconnector->dsc_aux, DP_DSC_ENABLE, &enable_dsc, 1);
        }
 
        if (stream->signal == SIGNAL_TYPE_DISPLAY_PORT)
                return dm_helpers_dp_write_dpcd(ctx, stream->link, DP_DSC_ENABLE, &enable_dsc, 1);
 
-       return false;
+       return (ret > 0);
 }
 
 bool dm_helpers_is_dp_sink_present(struct dc_link *link)