ASoC: meson: fixes the missed kfree() for axg_card_add_tdm_loopback
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Fri, 17 Jul 2020 08:22:42 +0000 (16:22 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 17 Jul 2020 12:58:30 +0000 (13:58 +0100)
axg_card_add_tdm_loopback() misses to call kfree() in an error path. We
can use devm_kasprintf() to fix the issue, also improve maintainability.
So use it instead.

Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20200717082242.130627-1-jingxiangfeng@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/meson/axg-card.c

index 89f7f64..47f2d93 100644 (file)
@@ -116,7 +116,7 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card *card,
 
        lb = &card->dai_link[*index + 1];
 
-       lb->name = kasprintf(GFP_KERNEL, "%s-lb", pad->name);
+       lb->name = devm_kasprintf(card->dev, GFP_KERNEL, "%s-lb", pad->name);
        if (!lb->name)
                return -ENOMEM;