RDMA/hns: Remove meaningless prints
authorWenpeng Liang <liangwenpeng@huawei.com>
Fri, 20 Mar 2020 03:23:39 +0000 (11:23 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Mar 2020 19:52:28 +0000 (16:52 -0300)
ceq and aeq is a ring buffer, consumer index of them will be set to zero
after reaching the maximum value. The warning should be removed or it may
mislead the users.

Link: https://lore.kernel.org/r/1584674622-52773-8-git-send-email-liweihang@huawei.com
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_hw_v1.c
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 2e53045..5ff028d 100644 (file)
@@ -3935,10 +3935,8 @@ static int hns_roce_v1_aeq_int(struct hns_roce_dev *hr_dev,
                eq->cons_index++;
                aeqes_found = 1;
 
-               if (eq->cons_index > 2 * hr_dev->caps.aeqe_depth - 1) {
-                       dev_warn(dev, "cons_index overflow, set back to 0.\n");
+               if (eq->cons_index > 2 * hr_dev->caps.aeqe_depth - 1)
                        eq->cons_index = 0;
-               }
        }
 
        set_eq_cons_index_v1(eq, 0);
@@ -3988,11 +3986,8 @@ static int hns_roce_v1_ceq_int(struct hns_roce_dev *hr_dev,
                ceqes_found = 1;
 
                if (eq->cons_index >
-                   EQ_DEPTH_COEFF * hr_dev->caps.ceqe_depth - 1) {
-                       dev_warn(&eq->hr_dev->pdev->dev,
-                               "cons_index overflow, set back to 0.\n");
+                   EQ_DEPTH_COEFF * hr_dev->caps.ceqe_depth - 1)
                        eq->cons_index = 0;
-               }
        }
 
        set_eq_cons_index_v1(eq, 0);
index aff7c5d..bd14e71 100644 (file)
@@ -5361,7 +5361,6 @@ static struct hns_roce_ceqe *next_ceqe_sw_v2(struct hns_roce_eq *eq)
 static int hns_roce_v2_ceq_int(struct hns_roce_dev *hr_dev,
                               struct hns_roce_eq *eq)
 {
-       struct device *dev = hr_dev->dev;
        struct hns_roce_ceqe *ceqe = next_ceqe_sw_v2(eq);
        int ceqe_found = 0;
        u32 cqn;
@@ -5380,10 +5379,8 @@ static int hns_roce_v2_ceq_int(struct hns_roce_dev *hr_dev,
                ++eq->cons_index;
                ceqe_found = 1;
 
-               if (eq->cons_index > (EQ_DEPTH_COEFF * eq->entries - 1)) {
-                       dev_warn(dev, "cons_index overflow, set back to 0.\n");
+               if (eq->cons_index > (EQ_DEPTH_COEFF * eq->entries - 1))
                        eq->cons_index = 0;
-               }
 
                ceqe = next_ceqe_sw_v2(eq);
        }