selftests/bpf: bring back (void *) cast to set_ipv4_csum in test_tc_tunnel
authorStanislav Fomichev <sdf@google.com>
Thu, 11 Apr 2019 22:53:16 +0000 (15:53 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 16 Apr 2019 07:51:48 +0000 (09:51 +0200)
It was removed in commit 166b5a7f2ca3 ("selftests_bpf: extend
test_tc_tunnel for UDP encap") without any explanation.

Otherwise I see:
progs/test_tc_tunnel.c:160:17: warning: taking address of packed member 'ip' of class or structure
      'v4hdr' may result in an unaligned pointer value [-Waddress-of-packed-member]
        set_ipv4_csum(&h_outer.ip);
                       ^~~~~~~~~~
1 warning generated.

Cc: Alan Maguire <alan.maguire@oracle.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Fixes: 166b5a7f2ca3 ("selftests_bpf: extend test_tc_tunnel for UDP encap")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Acked-by: Song Liu <songliubraving@fb.com>
Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
tools/testing/selftests/bpf/progs/test_tc_tunnel.c

index bcb00d7..ab56a6a 100644 (file)
@@ -157,7 +157,7 @@ static __always_inline int encap_ipv4(struct __sk_buff *skb, __u8 encap_proto,
                                       bpf_ntohs(h_outer.ip.tot_len));
        h_outer.ip.protocol = encap_proto;
 
-       set_ipv4_csum(&h_outer.ip);
+       set_ipv4_csum((void *)&h_outer.ip);
 
        /* store new outer network header */
        if (bpf_skb_store_bytes(skb, ETH_HLEN, &h_outer, olen,