e_mod_split_screen_manager: use defined string instead of use string repeatedly 80/292080/2
authorJunseok Kim <juns.kim@samsung.com>
Thu, 27 Apr 2023 04:54:51 +0000 (13:54 +0900)
committerJunseok Kim <juns.kim@samsung.com>
Thu, 27 Apr 2023 05:31:03 +0000 (14:31 +0900)
Change-Id: I9c194ebf5694bd3ff76b6021b9d8000442ef9e66

src/splitscreen/e_mod_split_screen_manager.c

index 98b2770..3c6682c 100644 (file)
@@ -4,6 +4,10 @@
 #include "e_mod_split_screen_region.h"
 #include "e_mod_appinfo_ext.h"
 
+#define E_MOD_SPLIT_SCREEN_SUB_REGION1 "sub1"
+#define E_MOD_SPLIT_SCREEN_SUB_REGION2 "sub2"
+#define E_MOD_SPLIT_SCREEN_SYSTEM_UI_REGION "SystemUI"
+
 typedef Eina_Bool (*E_Mod_Split_Screen_Manager_Hint_Func)(E_Client *ec, const char *name, const char *value);
 struct _E_Mod_Split_Screen_Manager_Hint_Handler
 {
@@ -261,10 +265,10 @@ _e_mod_split_screen_manager_hint_assign_region_sub1(E_Client *ec, const char *na
 
    appid = eina_stringshare_add(value);
 
-   emssr = _e_mod_split_screen_manager_find_region_by_name("sub1");
+   emssr = _e_mod_split_screen_manager_find_region_by_name(E_MOD_SPLIT_SCREEN_SUB_REGION1);
    if (!emssr)
      {
-        SSMERR("invalid region name:%s", ec, "sub1");
+        SSMERR("invalid region name:%s", ec, E_MOD_SPLIT_SCREEN_SUB_REGION1);
         return EINA_FALSE;
      }
 
@@ -289,10 +293,10 @@ _e_mod_split_screen_manager_hint_assign_region_sub2(E_Client *ec, const char *na
 
    appid = eina_stringshare_add(value);
 
-   emssr = _e_mod_split_screen_manager_find_region_by_name("sub2");
+   emssr = _e_mod_split_screen_manager_find_region_by_name(E_MOD_SPLIT_SCREEN_SUB_REGION2);
    if (!emssr)
      {
-        SSMERR("invalid region name:%s", ec, "sub2");
+        SSMERR("invalid region name:%s", ec, E_MOD_SPLIT_SCREEN_SUB_REGION2);
         return EINA_FALSE;
      }
 
@@ -336,7 +340,7 @@ _e_mod_split_screen_manager_client_manager_role_set(E_Client *ec, Eina_Bool set)
 
              desk = e_desk_current_get(e_zone_current_get());
              if (desk && desk->desk_area.enable)
-               _e_mod_split_screen_manager_ec_assign_to_region_name(ec, "SystemUI");
+               _e_mod_split_screen_manager_ec_assign_to_region_name(ec, E_MOD_SPLIT_SCREEN_SYSTEM_UI_REGION);
           }
         else
           {
@@ -374,7 +378,7 @@ _e_mod_split_screen_activate(E_Zone *zone)
    // launcher window must be above desk group to unobscured by other windows
    launcher = _e_mod_split_screen_launcher_ec_get();
    if (launcher)
-     _e_mod_split_screen_manager_ec_assign_to_region_name(launcher, "SystemUI");
+     _e_mod_split_screen_manager_ec_assign_to_region_name(launcher, E_MOD_SPLIT_SCREEN_SYSTEM_UI_REGION);
 
    return ret;
 }
@@ -510,7 +514,7 @@ _e_mod_split_screen_manager_ec_relocate(E_Client *ec)
    if (_e_mod_split_screen_manager_util_client_special_check(ec))
      {
         // special prupose windows.
-        _e_mod_split_screen_manager_ec_assign_to_region_name(ec, "SystemUI");
+        _e_mod_split_screen_manager_ec_assign_to_region_name(ec, E_MOD_SPLIT_SCREEN_SYSTEM_UI_REGION);
         return EINA_TRUE;
      }
 
@@ -638,17 +642,17 @@ _e_mod_split_screen_manager_region_init(void)
    desk_w = desk->geom.w;
    desk_h = desk->geom.h;
 
-   emssr_sub1 = e_mod_split_screen_region_new("sub1", desk_x, desk_y, desk_w, desk_h / 2);
+   emssr_sub1 = e_mod_split_screen_region_new(E_MOD_SPLIT_SCREEN_SUB_REGION1, desk_x, desk_y, desk_w, desk_h / 2);
    if (!emssr_sub1) return EINA_FALSE;
 
    _e_mod_split_screen_region_list = eina_list_append(_e_mod_split_screen_region_list, emssr_sub1);
 
-   emssr_sub2 = e_mod_split_screen_region_new("sub2", desk_x, desk_y + desk_h / 2, desk_w, desk_h / 2);
+   emssr_sub2 = e_mod_split_screen_region_new(E_MOD_SPLIT_SCREEN_SUB_REGION2, desk_x, desk_y + desk_h / 2, desk_w, desk_h / 2);
    if (!emssr_sub2) return EINA_FALSE;
 
    _e_mod_split_screen_region_list = eina_list_append(_e_mod_split_screen_region_list, emssr_sub2);
 
-   emssr_system = e_mod_split_screen_region_new("SystemUI", desk_x, desk_y, desk_w, desk_h);
+   emssr_system = e_mod_split_screen_region_new(E_MOD_SPLIT_SCREEN_SYSTEM_UI_REGION, desk_x, desk_y, desk_w, desk_h);
    if (!emssr_system) return EINA_FALSE;
    e_mod_split_screen_region_need_maximize_set(emssr_system, EINA_FALSE);