mfd: kempld-core: Fix callback return value check
authorAmeya Palande <2ameya@gmail.com>
Thu, 26 Feb 2015 20:05:51 +0000 (12:05 -0800)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 17 Apr 2015 00:13:19 +0000 (20:13 -0400)
[ Upstream commit c8648508ebfc597058d2cd00b6c539110264a167 ]

On success, callback function returns 0. So invert the if condition
check so that we can break out of loop.

Cc: stable@vger.kernel.org
Signed-off-by: Ameya Palande <2ameya@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/mfd/kempld-core.c

index bd26961..177fa31 100644 (file)
@@ -740,7 +740,7 @@ static int __init kempld_init(void)
                for (id = kempld_dmi_table;
                     id->matches[0].slot != DMI_NONE; id++)
                        if (strstr(id->ident, force_device_id))
-                               if (id->callback && id->callback(id))
+                               if (id->callback && !id->callback(id))
                                        break;
                if (id->matches[0].slot == DMI_NONE)
                        return -ENODEV;