f2fs: link f2fs quota ops for sysfile
authorJaegeuk Kim <jaegeuk@kernel.org>
Mon, 20 May 2019 23:17:56 +0000 (16:17 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 23 May 2019 14:03:11 +0000 (07:03 -0700)
This patch reverts:
commit fb40d618b039 ("f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG").

We were missing error handlers used in f2fs quota ops.

Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/super.c

index ed70b68..9c07b71 100644 (file)
@@ -1328,10 +1328,8 @@ static void update_ckpt_flags(struct f2fs_sb_info *sbi, struct cp_control *cpc)
 
        if (is_sbi_flag_set(sbi, SBI_QUOTA_SKIP_FLUSH))
                __set_ckpt_flags(ckpt, CP_QUOTA_NEED_FSCK_FLAG);
-       /*
-        * TODO: we count on fsck.f2fs to clear this flag until we figure out
-        * missing cases which clear it incorrectly.
-        */
+       else
+               __clear_ckpt_flags(ckpt, CP_QUOTA_NEED_FSCK_FLAG);
 
        if (is_sbi_flag_set(sbi, SBI_QUOTA_NEED_REPAIR))
                __set_ckpt_flags(ckpt, CP_QUOTA_NEED_FSCK_FLAG);
index 6b959bb..56fa80c 100644 (file)
@@ -3160,10 +3160,7 @@ try_onemore:
 
 #ifdef CONFIG_QUOTA
        sb->dq_op = &f2fs_quota_operations;
-       if (f2fs_sb_has_quota_ino(sbi))
-               sb->s_qcop = &dquot_quotactl_sysfile_ops;
-       else
-               sb->s_qcop = &f2fs_quotactl_ops;
+       sb->s_qcop = &f2fs_quotactl_ops;
        sb->s_quota_types = QTYPE_MASK_USR | QTYPE_MASK_GRP | QTYPE_MASK_PRJ;
 
        if (f2fs_sb_has_quota_ino(sbi)) {