Take care fall-through case of switch in skia
authortzik <tzik@chromium.org>
Tue, 5 Jan 2016 08:35:50 +0000 (00:35 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 5 Jan 2016 08:35:50 +0000 (00:35 -0800)
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1549273002

Review URL: https://codereview.chromium.org/1549273002

include/gpu/GrTestUtils.h
include/gpu/GrTypesPriv.h

index 91f36ea2d9c09b37e2fdd96956d34e87c12e4758..8ffae09dddf6d914f1b6bfa70e91326c6635b338 100644 (file)
@@ -91,6 +91,7 @@ static inline uint8_t GrRandomCoverage(SkRandom* random) {
     switch (colorMode) {
         case kZero_CoverageMode:
             coverage = 0;
+            break;
         case kAllOnes_CoverageMode:
             coverage = 0xff;
             break;
index 6135c14c12198232b67e41dbc7ea63545a278634..6cbd6bb0be3de165bf27d82ea94d086c46258f4d 100644 (file)
@@ -178,6 +178,7 @@ static inline GrSLType GrVertexAttribTypeToSLType(GrVertexAttribType type) {
     switch (type) {
         default:
             SkFAIL("Unsupported type conversion");
+            return kVoid_GrSLType;
         case kUByte_GrVertexAttribType:
         case kFloat_GrVertexAttribType:
             return kFloat_GrSLType;