net/mlx4: clean up a type issue
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 25 Jul 2023 05:39:47 +0000 (08:39 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 27 Jul 2023 05:08:44 +0000 (22:08 -0700)
These functions returns type bool, not pointers, so return false instead
of NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/52d0814a-7287-4160-94b5-ac7939ac61c6@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/mcg.c

index f1716a8..24d0c7c 100644 (file)
@@ -294,7 +294,7 @@ static bool check_duplicate_entry(struct mlx4_dev *dev, u8 port,
        struct mlx4_promisc_qp *dqp, *tmp_dqp;
 
        if (port < 1 || port > dev->caps.num_ports)
-               return NULL;
+               return false;
 
        s_steer = &mlx4_priv(dev)->steer[port - 1];
 
@@ -375,7 +375,7 @@ static bool can_remove_steering_entry(struct mlx4_dev *dev, u8 port,
        bool ret = false;
 
        if (port < 1 || port > dev->caps.num_ports)
-               return NULL;
+               return false;
 
        s_steer = &mlx4_priv(dev)->steer[port - 1];