Fix a off by one error about which members need to use the string table.
authorRafael Espindola <rafael.espindola@gmail.com>
Fri, 12 Jul 2013 22:22:34 +0000 (22:22 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Fri, 12 Jul 2013 22:22:34 +0000 (22:22 +0000)
llvm-svn: 186216

llvm/test/Object/archive-format.test [new file with mode: 0644]
llvm/tools/llvm-ar/llvm-ar.cpp

diff --git a/llvm/test/Object/archive-format.test b/llvm/test/Object/archive-format.test
new file mode 100644 (file)
index 0000000..9ac2d63
--- /dev/null
@@ -0,0 +1,22 @@
+Test the exact archive format. In particular, test which file names use the
+string table or not.
+
+REQUIRES: shell
+
+RUN: mkdir -p %t
+RUN: cd %t
+
+RUN: echo bar > 0123456789abcde
+RUN: echo zed > 0123456789abcdef
+
+RUN: rm -f test.a
+RUN: llvm-ar rc test.a 0123456789abcde 0123456789abcdef
+RUN: cat test.a | FileCheck -strict-whitespace %s
+
+CHECK:      !<arch>
+CHECK-NEXT: //                                              18        `
+CHECK-NEXT: 0123456789abcdef/
+CHECK-NEXT: 0123456789abcde/{{.*}}  1000  1000  100664  4         `
+CHECK-NEXT: bar
+CHECK-NEXT: /0              {{.*}}  1000  1000  100664  4         `
+CHECK-NEXT: zed
index ab2a2f1..5f47654 100644 (file)
@@ -419,7 +419,7 @@ StringRef NewArchiveIterator::getNew() const {
 template <typename T>
 void addMember(std::vector<NewArchiveIterator> &Members,
                std::string &StringTable, T I, StringRef Name) {
-  if (Name.size() < 15) {
+  if (Name.size() < 16) {
     NewArchiveIterator NI(I, Twine(Name) + "/");
     Members.push_back(NI);
   } else {