dmaengine: iop-adma: make array 'handler' static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Sep 2019 16:37:26 +0000 (17:37 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 14 Oct 2019 08:28:08 +0000 (13:58 +0530)
Don't populate the array 'handler' on the stack but instead make it
static const. Makes the object code smaller by 80 bytes.

Before:
   text    data     bss     dec     hex filename
  38225    9084      64   47373    b90d drivers/dma/iop-adma.o

After:
   text    data     bss     dec     hex filename
  38081    9148      64   47293    b8bd drivers/dma/iop-adma.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20190905163726.19690-1-colin.king@canonical.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/iop-adma.c

index a3f942a..4dc5478 100644 (file)
@@ -1359,9 +1359,11 @@ static int iop_adma_probe(struct platform_device *pdev)
        iop_adma_device_clear_err_status(iop_chan);
 
        for (i = 0; i < 3; i++) {
-               irq_handler_t handler[] = { iop_adma_eot_handler,
-                                       iop_adma_eoc_handler,
-                                       iop_adma_err_handler };
+               static const irq_handler_t handler[] = {
+                       iop_adma_eot_handler,
+                       iop_adma_eoc_handler,
+                       iop_adma_err_handler
+               };
                int irq = platform_get_irq(pdev, i);
                if (irq < 0) {
                        ret = -ENXIO;