scsi: qla2xxx: Fix some memory corruption
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 25 Jan 2021 08:44:02 +0000 (11:44 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 27 Jan 2021 03:06:26 +0000 (22:06 -0500)
This was supposed to be "data" instead of "&data".  The current code will
corrupt the stack.

Link: https://lore.kernel.org/r/YA6E0geUlL9Hs04A@mwanda
Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host, target stats and initiator port")
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_bsg.c

index e45da05..bee8cf9 100644 (file)
@@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job)
 
                bsg_reply->reply_payload_rcv_len =
                        sg_copy_from_buffer(bsg_job->reply_payload.sg_list,
-                                           bsg_job->reply_payload.sg_cnt, &data,
+                                           bsg_job->reply_payload.sg_cnt, data,
                                            sizeof(struct ql_vnd_tgt_stats_resp));
 
                bsg_reply->result = DID_OK;