rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler
authorTian Tao <tiantao6@hisilicon.com>
Tue, 10 Nov 2020 09:35:47 +0000 (17:35 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 14 Nov 2020 22:39:02 +0000 (23:39 +0100)
Coccinelle noticed:
drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT
drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1605000947-32882-1-git-send-email-tiantao6@hisilicon.com
drivers/rtc/rtc-cpcap.c

index 800667d..38d576b 100644 (file)
@@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
 
        rtc->alarm_irq = platform_get_irq(pdev, 0);
        err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
-                                       cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE,
+                                       cpcap_rtc_alarm_irq,
+                                       IRQF_TRIGGER_NONE | IRQF_ONESHOT,
                                        "rtc_alarm", rtc);
        if (err) {
                dev_err(dev, "Could not request alarm irq: %d\n", err);
@@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
         */
        rtc->update_irq = platform_get_irq(pdev, 1);
        err = devm_request_threaded_irq(dev, rtc->update_irq, NULL,
-                                       cpcap_rtc_update_irq, IRQF_TRIGGER_NONE,
+                                       cpcap_rtc_update_irq,
+                                       IRQF_TRIGGER_NONE | IRQF_ONESHOT,
                                        "rtc_1hz", rtc);
        if (err) {
                dev_err(dev, "Could not request update irq: %d\n", err);