test: drop the valgrind make check wrappers from autotools
authorPeter Hutterer <peter.hutterer@who-t.net>
Wed, 4 Jan 2023 05:46:44 +0000 (15:46 +1000)
committerJihoon Kim <jihoon48.kim@samsung.com>
Fri, 17 Nov 2023 10:55:47 +0000 (19:55 +0900)
We have meson with a proper test suite setup and this currently breaks
the CI due to some Arch issues with glibc debuginfo packages. Let's just
drop this so we don't run valgrind unconditionally.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
configure.ac
test/Makefile.am

index a927dfff5e8ac75c4325d2fb43eb6f7b797289fd..455dbcaff1f6f19d72280635b6087598a17d3fcb 100644 (file)
@@ -59,12 +59,9 @@ AC_CHECK_LIB([m], [round])
 
 PKG_PROG_PKG_CONFIG()
 PKG_CHECK_MODULES(CHECK, [check >= 0.9.9], [HAVE_CHECK="yes"], [HAVE_CHECK="no"])
-if test "x$HAVE_CHECK" = "xyes"; then
-       AC_PATH_PROG(VALGRIND, [valgrind])
-else
+if test "x$HAVE_CHECK" != "xyes"; then
        AC_MSG_WARN([check not found - skipping building unit tests])
 fi
-AM_CONDITIONAL(HAVE_VALGRIND, [test "x$VALGRIND" != "x"])
 AM_CONDITIONAL(ENABLE_RUNTIME_TESTS, [test "x$HAVE_CHECK" = "xyes"])
 AM_CONDITIONAL(ENABLE_STATIC_LINK_TEST, [test "x$enable_static" = "xyes"])
 
index 5f0c008d9b899ae7a2806437838e8bf163095078..d6f4fe2dd8fbb4a16b1f2180126459d9d82e63ad 100644 (file)
@@ -89,24 +89,11 @@ test_kernel_SOURCES = \
 test_kernel_CFLAGS = -I$(top_srcdir)
 test_kernel_LDADD = $(CHECK_LIBS) $(top_builddir)/libevdev/libevdev.la
 
-if HAVE_VALGRIND
-VALGRIND_FLAGS=--leak-check=full \
-               --quiet \
-               --error-exitcode=3 \
-               --suppressions=$(srcdir)/valgrind.suppressions
-
-valgrind:
-               $(MAKE) check-TESTS CK_TIMEOUT_MULTIPLIER=10 LOG_COMPILER="$(VALGRIND)" LOG_FLAGS="$(VALGRIND_FLAGS)"
-
-check_local_deps += valgrind
-
-endif
-
 if GCOV_ENABLED
 
 CLEANFILES = gcov-reports/*.gcov gcov-reports/summary.txt *.gcno *.gcda
 
-gcov-report: generate-gcov-report.sh check-TESTS
+gcov-report: generate-gcov-report.sh
        $(AM_V_GEN)$(srcdir)/generate-gcov-report.sh gcov-reports $(top_builddir)/libevdev $(builddir)
 
 gcov: gcov-report