selftests/bpf: don't hardcode iptables/nc path in test_tcpnotify_user
authorStanislav Fomichev <sdf@google.com>
Thu, 17 Jan 2019 19:56:12 +0000 (11:56 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 23 Jan 2019 11:56:30 +0000 (12:56 +0100)
system() is calling shell which should find the appropriate full path
via $PATH. On some systems, full path to iptables and/or nc might be
different that we one we have hardcoded.

Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
tools/testing/selftests/bpf/test_tcpnotify_user.c

index 4e43537..86152d9 100644 (file)
@@ -148,17 +148,17 @@ int main(int argc, char **argv)
        pthread_create(&tid, NULL, poller_thread, (void *)&pmu_fd);
 
        sprintf(test_script,
-               "/usr/sbin/iptables -A INPUT -p tcp --dport %d -j DROP",
+               "iptables -A INPUT -p tcp --dport %d -j DROP",
                TESTPORT);
        system(test_script);
 
        sprintf(test_script,
-               "/usr/bin/nc 127.0.0.1 %d < /etc/passwd > /dev/null 2>&1 ",
+               "nc 127.0.0.1 %d < /etc/passwd > /dev/null 2>&1 ",
                TESTPORT);
        system(test_script);
 
        sprintf(test_script,
-               "/usr/sbin/iptables -D INPUT -p tcp --dport %d -j DROP",
+               "iptables -D INPUT -p tcp --dport %d -j DROP",
                TESTPORT);
        system(test_script);