atomisp: reserve ioctls to avoid ABI conflicts for customer
authorDavid Cohen <david.a.cohen@intel.com>
Fri, 20 Apr 2012 14:21:04 +0000 (17:21 +0300)
committerbuildbot <buildbot@intel.com>
Wed, 25 Apr 2012 08:36:55 +0000 (01:36 -0700)
BZ: 27960

Customer asked us to implement 2 ioctls for debug purpose. As such
ioctls can't be merged to our tree for security purpose, we're marking
them as reserved ioctls to avoid create ABI conflicts.

Change-Id: I26a83903ce5d3a01f1640e090db553a37c80b7db
Signed-off-by: David Cohen <david.a.cohen@intel.com>
Reviewed-on: http://android.intel.com:8080/44148
Reviewed-by: Wang, Wen W <wen.w.wang@intel.com>
Reviewed-by: Toivonen, Tuukka <tuukka.toivonen@intel.com>
Reviewed-by: Laakso, Antti <antti.laakso@intel.com>
Reviewed-by: Koski, Anttu <anttu.koski@intel.com>
Tested-by: Koski, Anttu <anttu.koski@intel.com>
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>
include/linux/atomisp.h

index 39d55c5..ef36d19 100644 (file)
@@ -626,6 +626,17 @@ struct v4l2_private_int_data {
 #define ATOMISP_IOC_ACC_DESTAB \
        _IOW('v', BASE_VIDIOC_PRIVATE + 54, struct atomisp_acc_fw_arg)
 
+/*
+ * Reserved ioctls. We have customer implementing it internally.
+ * We can't use both numbers to not cause ABI conflict.
+ * Anyway, those ioctls are hacks and not implemented by us:
+ *
+ * #define ATOMISP_IOC_G_SENSOR_REG \
+ *     _IOW('v', BASE_VIDIOC_PRIVATE + 55, struct atomisp_sensor_regs)
+ * #define ATOMISP_IOC_S_SENSOR_REG \
+ *     _IOW('v', BASE_VIDIOC_PRIVATE + 56, struct atomisp_sensor_regs)
+ */
+
 /*  ISP Private control IDs */
 #define V4L2_CID_ATOMISP_BAD_PIXEL_DETECTION \
        (V4L2_CID_PRIVATE_BASE + 0)