platform/chrome: cros_usbpd_logger: Add __printf annotation to append_str()
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Tue, 14 Apr 2020 20:12:39 +0000 (22:12 +0200)
committerBenson Leung <bleung@chromium.org>
Mon, 4 May 2020 21:02:01 +0000 (14:02 -0700)
This allows the compiler to verify the format strings vs the types of
the arguments. Also, silence the warning (triggered by W=1):

  cros_usbpd_logger.c:55:2: warning: function ‘append_str’ might be a
  candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Benson Leung <bleung@chromium.org>
drivers/platform/chrome/cros_usbpd_logger.c

index 7de3ea7..d169312 100644 (file)
@@ -46,6 +46,7 @@ static const char * const fault_names[] = {
        "---", "OCP", "fast OCP", "OVP", "Discharge"
 };
 
+__printf(3, 4)
 static int append_str(char *buf, int pos, const char *fmt, ...)
 {
        va_list args;