[llvm/DebugInfo] Print DW_AT_ranges offset as part of verifier error.
authorJonas Devlieghere <jonas@devlieghere.com>
Mon, 27 Apr 2020 22:41:56 +0000 (15:41 -0700)
committerJonas Devlieghere <jonas@devlieghere.com>
Mon, 27 Apr 2020 23:45:17 +0000 (16:45 -0700)
Print the DW_AT_ranges offset as part of the verifier error, like we do
for the DW_AT_stmt_list offset.

llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

index beca8cc..7458471 100644 (file)
@@ -458,7 +458,8 @@ unsigned DWARFVerifier::verifyDebugInfoAttribute(const DWARFDie &Die,
     // Make sure the offset in the DW_AT_ranges attribute is valid.
     if (auto SectionOffset = AttrValue.Value.getAsSectionOffset()) {
       if (*SectionOffset >= DObj.getRangesSection().Data.size())
-        ReportError("DW_AT_ranges offset is beyond .debug_ranges bounds:");
+        ReportError("DW_AT_ranges offset is beyond .debug_ranges bounds: " +
+                    llvm::formatv("{0:x8}", *SectionOffset));
       break;
     }
     ReportError("DIE has invalid DW_AT_ranges encoding:");
index c982320..2caf6ca 100644 (file)
@@ -2008,8 +2008,9 @@ TEST(DWARFDebugInfo, TestDwarfVerifyInvalidRanges) {
   ASSERT_TRUE((bool)ErrOrSections);
   std::unique_ptr<DWARFContext> DwarfContext =
       DWARFContext::create(*ErrOrSections, 8);
-  VerifyError(*DwarfContext,
-              "error: DW_AT_ranges offset is beyond .debug_ranges bounds:");
+  VerifyError(
+      *DwarfContext,
+      "error: DW_AT_ranges offset is beyond .debug_ranges bounds: 0x00001000");
 }
 
 TEST(DWARFDebugInfo, TestDwarfVerifyInvalidStmtList) {