Fixed to check whether Ethernet cable state changed callback exists when it is released

The callback can be registered for each connection handle
and the ref count is incremented each time it is registered.
However, when the callback is released,
the ref count is decremented without checking whether or not the callback is registered in the connection handle.
Therefore, the ref count can be 0 even though there is a valid callback, and the event may not be processed.

Change-Id: I0569e8d0a74ca647c5bcdba6c877e7374a89e6f9

diff --git a/packaging/capi-network-connection.spec b/packaging/capi-network-connection.spec
index b16b8b4efa46f8b350be73a47a2cc4537daa6164..4fbea543fd7d66aa09d29a8e584242450678dbbd 100755 (executable)
--- a/packaging/capi-network-connection.spec
+++ b/packaging/capi-network-connection.spec
@@ -1,6 +1,6 @@
 Name:          capi-network-connection
 Summary:       Network Connection library in TIZEN C API
-Version:       1.0.94
+Version:       1.0.95
 Release:       1
 Group:         System/Network
 License:       Apache-2.0

diff --git a/src/connection.c b/src/connection.c
index 3901e2e826bd65037a9d8ca15ed0ea647a63d1b1..9a736f2ee1b6217e20f3647656395f041b91949a 100755 (executable)
--- a/src/connection.c
+++ b/src/connection.c
@@ -382,7 +382,8 @@ static int __connection_set_ethernet_cable_state_changed_cb(connection_h connect
                                        __connection_cb_ethernet_cable_state_changed_cb);
 
        } else {
-               if (__connection_get_ethernet_cable_state_changed_callback_count() == 1)
+               if (__connection_get_ethernet_cable_state_changed_callback_count() == 1 &&
+                                 local_handle->ethernet_cable_state_changed_callback)
                        _connection_libnet_set_ethernet_cable_state_changed_cb(NULL);
        }
 
@@ -616,7 +617,7 @@ EXPORT_API int connection_get_mac_address(connection_h connection, connection_ty
 
                break;
        //LCOV_EXCL_STOP
-       default :
+       default:
                CONNECTION_LOG(CONNECTION_ERROR, "Invalid parameter"); //LCOV_EXCL_LINE
                return CONNECTION_ERROR_INVALID_PARAMETER; //LCOV_EXCL_LINE
        }