platform/x86: int3472/discrete: Drop a forward declaration

By swapping the definition of skl_int3472_discrete_remove() and
skl_int3472_discrete_probe() the forward declaration of the former can
be dropped. This is a good thing as it removes code duplication.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
Link: https://lore.kernel.org/r/20220920070101.907596-1-u.kleine-koenig@pengutronix.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
index ed4c9d7..974a132 100644 (file)
--- a/drivers/platform/x86/intel/int3472/discrete.c
+++ b/drivers/platform/x86/intel/int3472/discrete.c
@@ -331,7 +331,22 @@ static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472)
        return 0;
 }
 
-static int skl_int3472_discrete_remove(struct platform_device *pdev);
+static int skl_int3472_discrete_remove(struct platform_device *pdev)
+{
+       struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev);
+
+       gpiod_remove_lookup_table(&int3472->gpios);
+
+       if (int3472->clock.cl)
+               skl_int3472_unregister_clock(int3472);
+
+       gpiod_put(int3472->clock.ena_gpio);
+       gpiod_put(int3472->clock.led_gpio);
+
+       skl_int3472_unregister_regulator(int3472);
+
+       return 0;
+}
 
 static int skl_int3472_discrete_probe(struct platform_device *pdev)
 {
@@ -383,23 +398,6 @@ static int skl_int3472_discrete_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int skl_int3472_discrete_remove(struct platform_device *pdev)
-{
-       struct int3472_discrete_device *int3472 = platform_get_drvdata(pdev);
-
-       gpiod_remove_lookup_table(&int3472->gpios);
-
-       if (int3472->clock.cl)
-               skl_int3472_unregister_clock(int3472);
-
-       gpiod_put(int3472->clock.ena_gpio);
-       gpiod_put(int3472->clock.led_gpio);
-
-       skl_int3472_unregister_regulator(int3472);
-
-       return 0;
-}
-
 static const struct acpi_device_id int3472_device_id[] = {
        { "INT3472", 0 },
        { }